Skip to content

add two helpers for bv_typet #8350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2024
Merged

add two helpers for bv_typet #8350

merged 1 commit into from
Jun 20, 2024

Conversation

kroening
Copy link
Member

bv_typet is meant for bit-vectors without numerical interpretation, e.g., when constructing bit-masks. This adds two helper methods for creating a bv-typed constant with the frequently used bit patterns 0...0 and 1...1.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

bv_typet is meant for bit-vectors without numerical interpretation, e.g.,
when constructing bit-masks.  This adds two helper methods for creating a
bv-typed constant with the frequently used bit patterns 0...0 and 1...1.
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.36%. Comparing base (699331b) to head (977b3ee).
Report is 5 commits behind head on develop.

Files Patch % Lines
src/util/bitvector_types.cpp 50.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8350      +/-   ##
===========================================
+ Coverage    78.15%   78.36%   +0.20%     
===========================================
  Files         1726     1726              
  Lines       188869   188387     -482     
  Branches     18489    18445      -44     
===========================================
+ Hits        147614   147632      +18     
+ Misses       41255    40755     -500     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening marked this pull request as ready for review June 20, 2024 15:48
@tautschnig tautschnig merged commit ed47f6d into develop Jun 20, 2024
39 of 41 checks passed
@tautschnig tautschnig deleted the bv_typet-helpers branch June 20, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants