-
Notifications
You must be signed in to change notification settings - Fork 285
Fix support for mathematical types #8324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix support for mathematical types #8324
Conversation
34b8cbe
to
e5a11d2
Compare
e5a11d2
to
19a8310
Compare
cebcc43
to
9cd88b5
Compare
5a6f0b8
to
9d13355
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #8324 +/- ##
===========================================
+ Coverage 80.43% 80.48% +0.05%
===========================================
Files 1695 1697 +2
Lines 208285 208427 +142
Branches 73 73
===========================================
+ Hits 167524 167745 +221
+ Misses 40761 40682 -79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9d13355
to
fb0495e
Compare
We were missing front-end support for reals and did not consistently support all of integers, naturals, rationals, reals but instead would only handle varying subsets in each place.
611573c
to
dcb2725
Compare
src.get_sub().size() == 3 && | ||
src.get_sub()[0].id() == "root-obj") // (root-obj (+ ...) 1) | ||
{ | ||
DATA_INVARIANT_WITH_DIAGNOSTICS( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that a DATA_INVARIANT is the right choice here. This is a property of the output of another tool, which we have very little control over. I'd make this a proper exception.
This representation is used by Z3 for it covers a subset of irrational numbers in addition to rational numbers.
dcb2725
to
3e649e6
Compare
We were missing front-end support for reals and did not consistently support all of integers, naturals, rationals, reals but instead would only handle varying subsets in each place.