Skip to content

C++ front-end: Replace uses of namespacet::follow #8227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2024
Merged

C++ front-end: Replace uses of namespacet::follow #8227

merged 2 commits into from
Mar 5, 2024

Conversation

tautschnig
Copy link
Collaborator

This is deprecated. Use suitable variants of follow_tag instead.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Mar 4, 2024
@tautschnig tautschnig force-pushed the cleanup/no-follow-cpp branch from b1ab433 to 816f0fe Compare March 5, 2024 11:38
@tautschnig
C++ type checking: use reference_typet, pointer_typet
bf29f34 
Hoist type conversions up for improved type safety and clarity.
@tautschnig
C++ front-end: Replace uses of namespacet::follow
2b2fd14 
This is deprecated. Use suitable variants of `follow_tag` instead. Also
fixes cases that used the full type when we should be using a tag type
instead.
@tautschnig tautschnig force-pushed the cleanup/no-follow-cpp branch from 816f0fe to 2b2fd14 Compare March 5, 2024 13:27
@tautschnig tautschnig marked this pull request as ready for review March 5, 2024 13:27
@codecov Codecov
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 77.66323% with 65 lines in your changes are missing coverage. Please review.

Project coverage is 79.66%. Comparing base (6cad8ca) to head (2b2fd14).

Files Patch % Lines
src/cpp/cpp_typecheck_resolve.cpp 66.00% 17 Missing ⚠️
src/cpp/cpp_typecheck_conversions.cpp 89.28% 12 Missing ⚠️
src/cpp/cpp_typecheck_declaration.cpp 47.82% 12 Missing ⚠️
src/cpp/cpp_typecheck_initializer.cpp 10.00% 9 Missing ⚠️
src/cpp/cpp_typecheck_expr.cpp 70.83% 7 Missing ⚠️
src/cpp/expr2cpp.cpp 0.00% 5 Missing ⚠️
src/cpp/cpp_typecheck.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #8227   +/-   ##
========================================
  Coverage    79.66%   79.66%           
========================================
  Files         1682     1682           
  Lines       195371   195431   +60     
========================================
+ Hits        155642   155694   +52     
- Misses       39729    39737    +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig merged commit 6f628d8 into diffblue:develop Mar 5, 2024
@tautschnig tautschnig deleted the cleanup/no-follow-cpp branch March 5, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroening kroening kroening approved these changes

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

Assignees

@tautschnig tautschnig

Labels
C++ Front End cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tautschnig @kroening