Skip to content

Deprecate namespacet::follow #8209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

tautschnig
Copy link
Collaborator

Follows struct and union tags, but does not follow enum tags. This is not obvious from its documentation, and led to surprising behaviour as seen (and fixed) in #8203. Using suitable variants of follow_tag is safer.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Follows struct and union tags, but does not follow enum tags. This is
not obvious from its documentation, and led to surprising behaviour as
seen (and fixed) in diffblue#8203. Using
suitable variants of `follow_tag` is safer.
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1939544) 79.66% compared to head (c6fcb02) 79.66%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8209   +/-   ##
========================================
  Coverage    79.66%   79.66%           
========================================
  Files         1682     1682           
  Lines       195378   195378           
========================================
+ Hits        155642   155645    +3     
+ Misses       39736    39733    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening merged commit 2d07351 into diffblue:develop Feb 20, 2024
@tautschnig tautschnig deleted the cleanup/deprecate-follow branch February 20, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants