Skip to content

argc/argv modelling: argument string must remain in scope #8174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

tautschnig
Copy link
Collaborator

We previously produced an argument string that was marked DEAD before entering main, making accesses to argv[i] ones to a dead object.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig force-pushed the bugfixes/argc-argv-scope branch from b569a35 to d22fc5a Compare February 2, 2024 10:45
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d85d38) 79.69% compared to head (ab93890) 79.69%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8174   +/-   ##
========================================
  Coverage    79.69%   79.69%           
========================================
  Files         1680     1680           
  Lines       195242   195245    +3     
========================================
+ Hits        155604   155607    +3     
  Misses       39638    39638           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig force-pushed the bugfixes/argc-argv-scope branch from d22fc5a to b989585 Compare February 2, 2024 13:55
We previously produced an argument string that was marked DEAD before
entering main, making accesses to argv[i] ones to a dead object.
@tautschnig tautschnig force-pushed the bugfixes/argc-argv-scope branch from b989585 to ab93890 Compare February 2, 2024 15:43
@tautschnig tautschnig merged commit 5bdff46 into diffblue:develop Feb 2, 2024
@tautschnig tautschnig deleted the bugfixes/argc-argv-scope branch February 2, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants