Add union_exprt encoding support in incremental smt2 decision procedure
#7926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasspriggs
requested review from
peterschrammel,
NlightNFotis,
TGWDB and
esteffin
as code owners
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7926 +/- ##
===========================================
- Coverage 78.56% 77.88% -0.68%
===========================================
Files 1699 1701 +2
Lines 195804 195932 +128
===========================================
- Hits 153833 152604 -1229
- Misses 41971 43328 +1357
☔ View full report in Codecov by Sentry. |
esteffin
approved these changes
Sep 28, 2023
| class nondet_padding_exprt; | ||
| void validate_expr(const nondet_padding_exprt &padding); | ||
|
|
||
| const irep_idt ID_nondet_padding = "nondet_padding"; |
There was a problem hiding this comment.
⛏️ Move ID_nondet_padding to a public static member of class nondet_padding_exprt
This data structure will be used to allow encoding/lowering passes to insert padding bitvectors with non deteriministic values. Unlike the SAT decision procedures, generating an SMT formula for nondet padding will require a corresponding parameter-less function to be defined. This placeholder expression is intended to be inserted in lowering passes and then substituted at the point of term generation. Note that it doesn't quite make sense to use symbols for this as the decision procedure doesn't have mutable symbol table access and adding an extra decision procedure symbol table would have other complications.
thomasspriggs
force-pushed
the
tas/smt_union_exprt
branch
from
a05d703 to
ac9490d
Compare
thomasspriggs
force-pushed
the
tas/smt_union_exprt
branch
from
ac9490d to
c78a2f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #7914 Like the previous PR, I am attempting to keep this relatively small for ease of review. This PR adds support for
union_exprtand only tests this support via catch tests.I am planning to add support for
member_exprtapplied to unions in a follow-up PR. At which point it should be possible to make more complete union regression tests pass.