Skip to content

Encode union tag types in smt2 decision procedure #7914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

thomasspriggs
Copy link
Contributor

This is a first step towards union support and is only expected to be testable via unit test. I have raised this as a separate PR in an effort to keep the PRs for union support small and easy to review.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e02fd74) 78.94% compared to head (bd798a1) 77.60%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7914      +/-   ##
===========================================
- Coverage    78.94%   77.60%   -1.35%     
===========================================
  Files         1697     1697              
  Lines       195379   195427      +48     
===========================================
- Hits        154242   151658    -2584     
- Misses       41137    43769    +2632     
Files Coverage Δ
...vers/smt2_incremental/encoding/struct_encoding.cpp 96.26% <100.00%> (+1.16%) ⬆️
...vers/smt2_incremental/encoding/struct_encoding.cpp 100.00% <100.00%> (ø)

... and 70 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This is a first step towards union support and is only expected to be
testable via unit test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants