Skip to content

GitHub actions: No need for setup-nuget #7917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

As per setup-nuget's documentation, setup-msbuild also takes care of making nuget available. Since we need the latter anyway, just move it earlier in the sequence of steps and remove a dependency (on setup-nuget).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig added the CI label Sep 26, 2023
@tautschnig tautschnig self-assigned this Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e02fd74) 78.94% compared to head (95340fa) 79.01%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7917      +/-   ##
===========================================
+ Coverage    78.94%   79.01%   +0.07%     
===========================================
  Files         1697     1697              
  Lines       195379   195379              
===========================================
+ Hits        154242   154386     +144     
+ Misses       41137    40993     -144     

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

As per setup-nuget's documentation, setup-msbuild also takes care of
making `nuget` available. Since we need the latter anyway, just move it
earlier in the sequence of steps and remove a dependency (on
setup-nuget).
@tautschnig tautschnig force-pushed the cleanup/remove-setup-nuget branch from 27c083a to 95340fa Compare September 26, 2023 18:42
@tautschnig tautschnig marked this pull request as ready for review September 26, 2023 18:47
@tautschnig tautschnig requested a review from a team as a code owner September 26, 2023 18:47
@tautschnig tautschnig assigned TGWDB and unassigned tautschnig Sep 26, 2023
@NlightNFotis NlightNFotis merged commit d38017c into diffblue:develop Sep 27, 2023
@tautschnig tautschnig deleted the cleanup/remove-setup-nuget branch September 27, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants