GitHub actions: No need for setup-nuget

As per setup-nuget's documentation, setup-msbuild also takes care of
making `nuget` available. Since we need the latter anyway, just move it
earlier in the sequence of steps and remove a dependency (on
setup-nuget).

Author: tautschnig

.github/workflows/pull-request-checks.yaml

@@ -675,9 +675,8 @@ jobs:
       - uses: actions/checkout@v3
         with:
           submodules: recursive
-      - uses: nuget/setup-nuget@v1
-        with:
-          nuget-version: '5.8.x'
+      - name: Setup Visual Studio environment
+        uses: microsoft/setup-msbuild@v1
       - name: Fetch dependencies
         run: |
           choco install winflexbison3
@@ -698,8 +697,6 @@ jobs:
         run: z3 --version
       - name: Confirm cvc5 solver is available and log the version installed
         run: cvc5 --version
-      - name: Setup Visual Studio environment
-        uses: microsoft/setup-msbuild@v1
       - name: Prepare ccache
         uses: actions/cache@v3
         with:
@@ -733,9 +730,8 @@ jobs:
       - uses: actions/checkout@v3
         with:
           submodules: recursive
-      - uses: nuget/setup-nuget@v1
-        with:
-          nuget-version: '5.8.x'
+      - name: Setup MSBuild
+        uses: microsoft/setup-msbuild@v1
       - name: Fetch dependencies
         run: |
           choco install -y winflexbison3 strawberryperl wget
@@ -758,8 +754,6 @@ jobs:
         run: z3 --version
       - name: Confirm cvc5 solver is available and log the version installed
         run: cvc5 --version
-      - name: Setup MSBuild
-        uses: microsoft/setup-msbuild@v1
       - name: Initialise Developer Command Line
         uses: ilammy/msvc-dev-cmd@v1
       - name: Prepare ccache
@@ -805,9 +799,8 @@ jobs:
       - uses: actions/checkout@v3
         with:
           submodules: recursive
-      - uses: nuget/setup-nuget@v1
-        with:
-          nuget-version: '5.8.x'
+      - name: Setup Visual Studio environment
+        uses: microsoft/setup-msbuild@v1
       - name: Fetch dependencies
         run: |
           choco install winflexbison3
@@ -818,8 +811,6 @@ jobs:
           }
           nuget install clcache -OutputDirectory "c:\tools" -ExcludeVersion -Version 4.1.0
           echo "c:\tools\clcache\clcache-4.1.0" >> $env:GITHUB_PATH
-      - name: Setup Visual Studio environment
-        uses: microsoft/setup-msbuild@v1
       - name: Prepare ccache
         uses: actions/cache@v3
         with:

.github/workflows/release-packages.yaml

@@ -187,16 +187,13 @@ jobs:
       - uses: actions/checkout@v3
         with:
           submodules: recursive
-      - uses: nuget/setup-nuget@v1
-        with:
-          nuget-version: '5.8.x'
+      - name: Setup Visual Studio environment
+        uses: microsoft/setup-msbuild@v1
       - name: Fetch dependencies
         run: |
           choco install winflexbison3
           nuget install clcache -OutputDirectory "c:\tools" -ExcludeVersion -Version 4.1.0
           echo "c:\tools\clcache\clcache-4.1.0" >> $env:GITHUB_PATH
-      - name: Setup Visual Studio environment
-        uses: microsoft/setup-msbuild@v1
       - name: Setup code sign environment
         run: |
           echo "$(Split-Path -Path $(Get-ChildItem -Path "${env:ProgramFiles(x86)}\Windows Kits\10\App Certification Kit\signtool.exe"))" >> $env:GITHUB_PATH