Skip to content

Clean up implementation of goto binary writing #7634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thomasspriggs
Copy link
Contributor

This refactoring PR is preparatory work for #7633

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Because it serialises two separate things and this helps make the
functions smaller and separate the two separate steps.
These no-longer serve any value as the functions being called no longer
exist and there is no indication that they might be needed.
This function always returned `false` and was not exposed in the header
file. Therefore we can freely update it to return `void` without causing
problems for users of the serialisation code.
In order to make it clear that functions with no body are not
serialised, without reading the code below the if block.
Because we plan to add more writes to the functions loop and this helps
make the boundaries between the code which writes different outputs
clearer.
So that the code explains what is being written to file without the need
for the `// name` comment.
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06 ⚠️

Comparison is base (378c902) 78.51% compared to head (69ec03b) 78.45%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7634      +/-   ##
===========================================
- Coverage    78.51%   78.45%   -0.06%     
===========================================
  Files         1671     1671              
  Lines       191848   191827      -21     
===========================================
- Hits        150621   150492     -129     
- Misses       41227    41335     +108     
Impacted Files Coverage Δ
src/goto-programs/write_goto_binary.cpp 85.00% <100.00%> (-3.89%) ⬇️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig merged commit e0aa536 into diffblue:develop Mar 29, 2023
@feliperodri feliperodri added the aws Bugs or features of importance to AWS CBMC users label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Bugs or features of importance to AWS CBMC users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants