Clean up implementation of goto binary writing #7634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it serialises two separate things and this helps make the functions smaller and separate the two separate steps.
These no-longer serve any value as the functions being called no longer exist and there is no indication that they might be needed.
This function always returned `false` and was not exposed in the header file. Therefore we can freely update it to return `void` without causing problems for users of the serialisation code.
In order to make it clear that functions with no body are not serialised, without reading the code below the if block.
Because we plan to add more writes to the functions loop and this helps make the boundaries between the code which writes different outputs clearer.
So that the code explains what is being written to file without the need for the `// name` comment.
thomasspriggs
requested review from
kroening,
tautschnig and
peterschrammel
as code owners
7 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7634 +/- ##
===========================================
- Coverage 78.51% 78.45% -0.06%
===========================================
Files 1671 1671
Lines 191848 191827 -21
===========================================
- Hits 150621 150492 -129
- Misses 41227 41335 +108
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
tautschnig
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring PR is preparatory work for #7633