SMT back-end: report too-many-addressed-objects

[tautschnig]

Fail generation of the SMT encoding with a meaningful error message rather than generating invalid SMT-LIB output. The behaviour now matches that of the SAT back-end.

Fixes: #7623

• Each commit message has a non-empty body, explaining why the change was made.
• n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[TGWDB]

A quick look shows that the new SMT2 backend has a different message here, any chance that could also be updated here?

Approving since this is a fix for the old SMT backend.

[tautschnig]

A quick look shows that the new SMT2 backend has a different message here, any chance that could also be updated here?

Good call-out! Fix included.

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b34e991) 78.50% compared to head (2888ad3) 78.51%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #7624   +/-   ##
========================================
  Coverage    78.50%   78.51%           
========================================
  Files         1671     1671           
  Lines       191847   191848    +1     
========================================
+ Hits        150618   150621    +3     
+ Misses       41229    41227    -2     

Impacted Files	Coverage Δ
...c/solvers/smt2_incremental/convert_expr_to_smt.cpp	89.59% <ø> (-0.07%)	⬇️
src/solvers/smt2/smt2_conv.cpp	67.37% <100.00%> (+0.11%)	⬆️
...t/solvers/smt2_incremental/convert_expr_to_smt.cpp	99.60% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.