Skip to content

Array_UF21 does not always work with incremental SMT back-end #7501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

tautschnig
Copy link
Collaborator

The test consistently fails when doing coverage checking (was also the case in the coverage check run of #7434, which was the PR introducing this test). The output is:
Invalid SMT response "corrupted"
The test appears to be working fine when not doing coverage checking, though.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The test consistently fails when doing coverage checking (was also the
case in the coverage check run of diffblue#7434, which was the PR introducing this
test). The output is:
`Invalid SMT response "corrupted"`
The test appears to be working fine when not doing coverage checking,
though.
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 78.48% // Head: 78.22% // Decreases project coverage by -0.26% ⚠️

Coverage data is based on head (1eb8803) compared to base (e913535).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7501      +/-   ##
===========================================
- Coverage    78.48%   78.22%   -0.26%     
===========================================
  Files         1663     1663              
  Lines       191232   191249      +17     
===========================================
- Hits        150082   149609     -473     
- Misses       41150    41640     +490     
Impacted Files Coverage Δ
src/util/pointer_offset_sum.cpp 0.00% <0.00%> (-60.00%) ⬇️
src/util/validate_types.cpp 40.00% <0.00%> (-53.34%) ⬇️
src/util/type.cpp 27.27% <0.00%> (-45.46%) ⬇️
src/util/cout_message.cpp 40.74% <0.00%> (-44.45%) ⬇️
src/util/validate_helpers.h 55.55% <0.00%> (-44.45%) ⬇️
src/util/typecheck.cpp 31.25% <0.00%> (-43.75%) ⬇️
src/util/irep_hash_container.cpp 36.36% <0.00%> (-36.37%) ⬇️
src/util/ssa_expr.cpp 58.25% <0.00%> (-35.93%) ⬇️
src/util/timestamper.h 33.33% <0.00%> (-33.34%) ⬇️
src/big-int/bigint.cc 59.58% <0.00%> (-29.43%) ⬇️
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@thomasspriggs thomasspriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added this test to our team's list of tests for further investigation.

@thomasspriggs thomasspriggs merged commit 031ae2e into diffblue:develop Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants