Skip to content

Output solver stats on --stop-on-fail #7485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

peterschrammel
Copy link
Member

We previously only output it when checking all properties.

  • Each commit message has a non-empty body, explaining why the change was made.
  • [n/a] Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • [n/a] The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • [X Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [n/a] My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • [n/a] White-space or formatting changes outside the feature-related changed lines are in commits of their own.

We previously only output it when checking all properties.
@peterschrammel peterschrammel force-pushed the solver-stats-stop-on-fail branch from dcb27d0 to 04b527c Compare January 18, 2023 10:42
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 78.48% // Head: 78.48% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (04b527c) compared to base (f76d7fa).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7485   +/-   ##
========================================
  Coverage    78.48%   78.48%           
========================================
  Files         1663     1663           
  Lines       191188   191189    +1     
========================================
+ Hits        150054   150055    +1     
  Misses       41134    41134           
Impacted Files Coverage Δ
src/goto-checker/stop_on_fail_verifier.h 78.57% <100.00%> (+0.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@peterschrammel peterschrammel marked this pull request as ready for review January 18, 2023 14:56
@tautschnig tautschnig self-assigned this Jan 18, 2023
@@ -71,6 +71,7 @@ class stop_on_fail_verifiert : public goto_verifiert
report_error(ui_message_handler);
break;
}
incremental_goto_checker.report();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at the code some more I can see that/why this works, but I find it rather subtle. Would it perhaps be better to copy what multi_path_symex_checkert::report() does?

Copy link
Member Author

@peterschrammel peterschrammel Jan 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mirroring what we already do in all_properties_verifier.
It was forgotten to add the report() call to this verifier too.

@peterschrammel peterschrammel merged commit 556029c into diffblue:develop Jan 18, 2023
@peterschrammel peterschrammel deleted the solver-stats-stop-on-fail branch January 18, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants