Skip to content

Cleanup of pointer-in-range predicate handling #7459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

tautschnig
Copy link
Collaborator

Make sure expr2ct knows how to print it, add a full API, cleanup comments.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Make sure expr2ct knows how to print it, add a full API, cleanup
comments.
@tautschnig tautschnig force-pushed the cleanup/pointer-in-range branch from 3f951aa to 08fde08 Compare January 3, 2023 21:45
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 78.48% // Head: 78.47% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (08fde08) compared to base (43f71f3).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7459      +/-   ##
===========================================
- Coverage    78.48%   78.47%   -0.01%     
===========================================
  Files         1663     1663              
  Lines       191136   191174      +38     
===========================================
+ Hits        150017   150033      +16     
- Misses       41119    41141      +22     
Impacted Files Coverage Δ
src/ansi-c/c_typecheck_expr.cpp 76.06% <ø> (ø)
src/ansi-c/expr2c_class.h 100.00% <ø> (ø)
src/util/pointer_expr.h 96.72% <25.00%> (-2.31%) ⬇️
src/ansi-c/expr2c.cpp 67.71% <53.84%> (-0.17%) ⬇️
src/goto-programs/link_to_library.cpp 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kroening kroening merged commit 78d7b49 into diffblue:develop Jan 5, 2023
@tautschnig tautschnig deleted the cleanup/pointer-in-range branch January 5, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants