Skip to content

GitHub actions: use checkout v3 #7245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

tautschnig
Copy link
Collaborator

This avoids a warning about a deprected node.js version (version 12).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This avoids a warning about a deprected node.js version (version 12).
Copy link
Contributor

@thomasspriggs thomasspriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the equivalent change also needs to be done for the Java models library. Is anyone else already looking at this? https://github.com/diffblue/java-models-library/blob/012cdc25d95ef13ea99123683d0db9044254388d/.github/workflows/models_library_pr.yml#L11

@tautschnig
Copy link
Collaborator Author

It looks like the equivalent change also needs to be done for the Java models library. Is anyone else already looking at this? https://github.com/diffblue/java-models-library/blob/012cdc25d95ef13ea99123683d0db9044254388d/.github/workflows/models_library_pr.yml#L11

Can this be taken care of by someone on the Diffblue team?

@tautschnig tautschnig merged commit 8a314e8 into diffblue:develop Oct 17, 2022
@tautschnig tautschnig deleted the cleanup/checkout-v3 branch October 17, 2022 14:35
@thomasspriggs
Copy link
Contributor

It looks like the equivalent change also needs to be done for the Java models library. Is anyone else already looking at this? https://github.com/diffblue/java-models-library/blob/012cdc25d95ef13ea99123683d0db9044254388d/.github/workflows/models_library_pr.yml#L11

Can this be taken care of by someone on the Diffblue team?

Yes I am happy to take care of this. I just didn't want to duplicate anyone else's efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants