Skip to content

Clarify commands in test comments required for goto-binary version changes #6795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

These goto binaries are kept in the repository and need to be recompiled
when goto-binary versions change.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

…anges

These goto binaries are kept in the repository and need to be recompiled
when goto-binary versions change.
@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Merging #6795 (31ea1cf) into develop (b7c6692) will increase coverage by 0.07%.
The diff coverage is 89.32%.

@@             Coverage Diff             @@
##           develop    #6795      +/-   ##
===========================================
+ Coverage    76.90%   76.97%   +0.07%     
===========================================
  Files         1590     1593       +3     
  Lines       183969   184109     +140     
===========================================
+ Hits        141486   141726     +240     
+ Misses       42483    42383     -100     
Impacted Files Coverage Δ
..._incremental/smt2_incremental_decision_procedure.h 75.00% <ø> (ø)
...c/solvers/smt2_incremental/convert_expr_to_smt.cpp 84.87% <76.74%> (+12.78%) ⬆️
src/solvers/smt2_incremental/object_tracking.cpp 97.87% <97.87%> (ø)
src/goto-programs/goto_function.cpp 100.00% <100.00%> (ø)
src/solvers/smt2_incremental/object_tracking.h 100.00% <100.00%> (ø)
...ncremental/smt2_incremental_decision_procedure.cpp 94.15% <100.00%> (+0.14%) ⬆️
...t/solvers/smt2_incremental/convert_expr_to_smt.cpp 100.00% <100.00%> (ø)
unit/solvers/smt2_incremental/object_tracking.cpp 100.00% <100.00%> (ø)
src/util/std_code.h 94.08% <0.00%> (+0.01%) ⬆️
src/util/pointer_offset_size.cpp 92.83% <0.00%> (+0.27%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a4c66e...31ea1cf. Read the comment docs.

@kroening kroening merged commit 41e9cfd into diffblue:develop May 6, 2022
@tautschnig tautschnig deleted the cleanup/recompile-instructions branch May 6, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants