Set base_name member for __CPROVER_start #6784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
peterschrammel,
pkesseli,
romainbrenguier and
chris-ryder
as code owners
kroening
approved these changes
Apr 6, 2022
The (un)reachable functions output uses the base_name in the output, which previously resulted in the surprising behaviour that an empty function name was printed. While falling back to the symbol's name may be possible, there could well be other places that try to use the `base_name`.
tautschnig
force-pushed
the
bugfixes/reachable-functions
branch
from
07b825d to
f0502d2
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6784 +/- ##
===========================================
+ Coverage 76.90% 76.97% +0.07%
===========================================
Files 1590 1593 +3
Lines 183969 184114 +145
===========================================
+ Hits 141486 141730 +244
+ Misses 42483 42384 -99
Continue to review full report at Codecov.
|
peterschrammel
approved these changes
May 17, 2022
| @@ -535,6 +535,7 @@ bool generate_ansi_c_start_function( | |||
| symbolt new_symbol; | |||
There was a problem hiding this comment.
💡 Maybe a proper constructor could help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The (un)reachable functions output uses the base_name in the output,
which previously resulted in the surprising behaviour that an empty
function name was printed. While falling back to the symbol's name may
be possible, there could well be other places that try to use the
base_name.