Add and use symbolt constructors #6591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
cleanup/symbolt
branch
from
6d5f793 to
8646cc1
Compare
Codecov ReportBase: 78.38% // Head: 78.32% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #6591 +/- ##
===========================================
- Coverage 78.38% 78.32% -0.06%
===========================================
Files 1647 1645 -2
Lines 190362 189922 -440
===========================================
- Hits 149213 148760 -453
- Misses 41149 41162 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tautschnig
force-pushed
the
cleanup/symbolt
branch
from
fbaf6ac to
b86362d
Compare
tautschnig
requested review from
chrisr-diffblue,
feliperodri,
kroening,
martin-cs,
peterschrammel,
pkesseli,
romainbrenguier and
SaswatPadhi
as code owners
|
To reviewers (multiple required): please review commit-by-commit, possibly choosing only those parts of the code that you actually care about (the parts can be inferred from the commit messages). |
chrisr-diffblue
approved these changes
Jan 20, 2022
There was a problem hiding this comment.
Whilst I'm not usually a massive fan of wide changes for the sake of them, I'm very happy to see this change - especially the dropping of lots of ...is_type=false :-)
Might be worth a quick sanity check with @martin-cs that this doesn't clash with anything urgent he may be working on - especially around gnat2goto and related projects.
| @@ -446,14 +446,10 @@ void java_bytecode_convert_classt::convert( | |||
| }(id2string(c.name)); | |||
|
|
|||
| // produce class symbol | |||
| symbolt new_symbol; | |||
| class_type.set_name(qualified_classname); | |||
| type_symbolt new_symbol{qualified_classname, class_type, ID_java}; | |||
feliperodri
approved these changes
Jan 20, 2022
tautschnig
force-pushed
the
cleanup/symbolt
branch
from
b86362d to
25c99ad
Compare
tautschnig
force-pushed
the
cleanup/symbolt
branch
3 times, most recently
from
9a33916 to
24e97f1
Compare
chris-ryder
approved these changes
Feb 5, 2022
tautschnig
force-pushed
the
cleanup/symbolt
branch
from
24e97f1 to
f7e0917
Compare
peterschrammel
approved these changes
Feb 24, 2022
tautschnig
force-pushed
the
cleanup/symbolt
branch
2 times, most recently
from
2c89546 to
508335e
Compare
3 tasks
tautschnig
force-pushed
the
cleanup/symbolt
branch
from
508335e to
5ac94dd
Compare
tautschnig
force-pushed
the
cleanup/symbolt
branch
from
5ac94dd to
223a764
Compare
|
|
tautschnig
force-pushed
the
cleanup/symbolt
branch
from
223a764 to
50deb2e
Compare
tautschnig
force-pushed
the
cleanup/symbolt
branch
2 times, most recently
from
ddbc0fb to
dc3abbe
Compare
tautschnig
force-pushed
the
cleanup/symbolt
branch
from
dc3abbe to
4fa5735
Compare
tautschnig
force-pushed
the
cleanup/symbolt
branch
from
4fa5735 to
60eaaad
Compare
To the extent possible, apply resource-acquisition-is-initialisation. The constructors ensure that at least the most essential fields (name, type, mode) are set. Constructors are now consistent in what they do, and do not set the base_name in addition to the name.
To the extent possible, apply resource-acquisition-is-initialisation. The constructors ensure that at least the most essential fields (name, type, mode) are set.
To the extent possible, apply resource-acquisition-is-initialisation. The constructors ensure that at least the most essential fields (name, type, mode) are set.
To the extent possible, apply resource-acquisition-is-initialisation. The constructors ensure that at least the most essential fields (name, type, mode) are set.
To the extent possible, apply resource-acquisition-is-initialisation. The constructors ensure that at least the most essential fields (name, type, mode) are set.
To the extent possible, apply resource-acquisition-is-initialisation. The constructors ensure that at least the most essential fields (name, type, mode) are set.
To the extent possible, apply resource-acquisition-is-initialisation. The constructors ensure that at least the most essential fields (name, type, mode) are set.
To the extent possible, apply resource-acquisition-is-initialisation. The constructors ensure that at least the most essential fields (name, type, mode) are set.
To the extent possible, apply resource-acquisition-is-initialisation. The constructors ensure that at least the most essential fields (name, type, mode) are set.
To the extent possible, apply resource-acquisition-is-initialisation. The constructors ensure that at least the most essential fields (name, type, mode) are set.
tautschnig
force-pushed
the
cleanup/symbolt
branch
from
60eaaad to
6ac16bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To the extent possible, apply resource-acquisition-is-initialisation.
The constructors ensure that at least the most essential fields (name,
type, mode) are set.