add more formatters #6724
Merged
add more formatters #6724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds to_ternary_expr, to upcast expressions with three operands.
kroening
force-pushed
the
more_formatters
branch
from
a3fb4dc to
809faac
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6724 +/- ##
========================================
Coverage 76.84% 76.85%
========================================
Files 1589 1589
Lines 183795 183846 +51
========================================
+ Hits 141238 141289 +51
Misses 42557 42557
Continue to review full report at Codecov.
|
tautschnig
reviewed
Mar 14, 2022
src/util/format_type.cpp
Outdated
Comment on lines
118
to
122
| else if(id == "expression") | ||
| { | ||
| const auto &expression_type = to_type_with_subtype(type); | ||
| return os << format(expression_type.subtype()) << " expr"; | ||
| } |
There was a problem hiding this comment.
git grep expression_typet returns nothing. What is this?
This fixes the formatter for pointer-typed constant expressions.
This adds a formatter to format_expr for array_of_exprt expressions.
This adds a formatter to format_expr for address_of_exprt expressions.
This adds formatters to format_expr for floating-point expressions.
kroening
force-pushed
the
more_formatters
branch
from
809faac to
9053c5f
Compare
tautschnig
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a set of additional formatters for
format_expr.