Skip to content

MMIO rewriting must maintain type consistency #6683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2022

Conversation

tautschnig
Copy link
Collaborator

MMIO read functions may (have to) return values of varying types.
Expression replacement must maintain, via type casts, consistency with
whatever the type of the original expression was.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

MMIO read functions may (have to) return values of varying types.
Expression replacement must maintain, via type casts, consistency with
whatever the type of the original expression was.
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #6683 (871d3a5) into develop (222d266) will increase coverage by 0.00%.
The diff coverage is 97.08%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6683   +/-   ##
========================================
  Coverage    76.82%   76.82%           
========================================
  Files         1582     1582           
  Lines       182767   182770    +3     
========================================
+ Hits        140403   140411    +8     
+ Misses       42364    42359    -5     
Impacted Files Coverage Δ
src/goto-programs/string_abstraction.h 100.00% <ø> (ø)
unit/util/piped_process.cpp 31.29% <33.33%> (ø)
src/ansi-c/c_typecheck_expr.cpp 76.45% <50.00%> (ø)
src/goto-programs/string_abstraction.cpp 92.46% <90.90%> (ø)
src/goto-programs/mm_io.cpp 100.00% <100.00%> (ø)
...solvers/smt2_incremental/smt_bit_vector_theory.cpp 100.00% <100.00%> (ø)
...rc/solvers/smt2_incremental/smt_solver_process.cpp 68.57% <100.00%> (ø)
src/util/piped_process.cpp 81.92% <100.00%> (ø)
...solvers/smt2_incremental/smt_bit_vector_theory.cpp 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79c1637...871d3a5. Read the comment docs.

@kroening kroening merged commit 80186e3 into diffblue:develop Feb 20, 2022
@tautschnig tautschnig deleted the bugfixes/mmio-cast branch February 20, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants