Skip to content

Remove deprecated string abstraction methods #6673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tautschnig
Copy link
Collaborator

Parts of the string_abstractiont API were deprecated in 2020 and can
safely be removed.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Parts of the string_abstractiont API were deprecated in 2020 and can
safely be removed.
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #6673 (3f9f055) into develop (b26ad8b) will increase coverage by 0.05%.
The diff coverage is 99.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6673      +/-   ##
===========================================
+ Coverage    76.76%   76.81%   +0.05%     
===========================================
  Files         1582     1582              
  Lines       182360   182762     +402     
===========================================
+ Hits        139992   140397     +405     
+ Misses       42368    42365       -3     
Impacted Files Coverage Δ
src/goto-programs/string_abstraction.h 100.00% <ø> (ø)
src/goto-programs/string_abstraction.cpp 92.46% <88.23%> (+0.33%) ⬆️
...solvers/smt2_incremental/smt_bit_vector_theory.cpp 100.00% <100.00%> (ø)
...solvers/smt2_incremental/smt_bit_vector_theory.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3e1411...3f9f055. Read the comment docs.

@tautschnig tautschnig self-assigned this Feb 15, 2022
@tautschnig tautschnig merged commit 12ef9e7 into diffblue:develop Feb 15, 2022
@tautschnig tautschnig deleted the cleanup/remove-deprecated-string-abstraction-api branch February 15, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants