Skip to content

Simplify overflow-mult when one operand is 1 #6634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

1 (one) is a neutral element for multiplication.

Depending on the order of reviews/approvals, this PR or #6633 will require merge conflict resolution: #6633 introduces additional checks, some of which can be simplified away via the changes in this PR.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

1 (one) is a neutral element for multiplication.
@tautschnig tautschnig force-pushed the feature/simplify-overflow_mult branch from 82ba05d to c2cbaad Compare February 3, 2022 13:32
@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #6634 (c2cbaad) into develop (a638644) will increase coverage by 0.00%.
The diff coverage is 95.25%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6634   +/-   ##
========================================
  Coverage    76.65%   76.65%           
========================================
  Files         1580     1579    -1     
  Lines       181560   181612   +52     
========================================
+ Hits        139168   139220   +52     
  Misses       42392    42392           
Impacted Files Coverage Δ
src/goto-instrument/contracts/contracts.h 100.00% <ø> (ø)
src/goto-programs/restrict_function_pointers.h 100.00% <ø> (ø)
src/goto-instrument/contracts/utils.cpp 85.59% <80.55%> (ø)
src/goto-programs/restrict_function_pointers.cpp 80.27% <89.58%> (ø)
...trument/contracts/havoc_assigns_clause_targets.cpp 95.55% <93.33%> (ø)
...o-instrument/contracts/instrument_spec_assigns.cpp 95.35% <95.35%> (ø)
src/ansi-c/c_typecheck_code.cpp 79.92% <100.00%> (ø)
src/goto-instrument/contracts/contracts.cpp 90.75% <100.00%> (ø)
...nstrument/contracts/havoc_assigns_clause_targets.h 100.00% <100.00%> (ø)
...oto-instrument/contracts/instrument_spec_assigns.h 100.00% <100.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c0d865...c2cbaad. Read the comment docs.

@tautschnig tautschnig merged commit 3da0d96 into diffblue:develop Feb 3, 2022
@tautschnig tautschnig deleted the feature/simplify-overflow_mult branch February 3, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants