Skip to content

Remove spurious use of ID_property #6632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

tautschnig
Copy link
Collaborator

This perhaps was meant to be "property_class," but really we should just
leave it as was provided in the source location.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #6632 (143c49c) into develop (1154f13) will increase coverage by 0.17%.
The diff coverage is 87.59%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6632      +/-   ##
===========================================
+ Coverage    76.92%   77.10%   +0.17%     
===========================================
  Files         1583     1582       -1     
  Lines       183314   182630     -684     
===========================================
- Hits        141018   140820     -198     
+ Misses       42296    41810     -486     
Impacted Files Coverage Δ
src/cpp/cpp_typecheck_conversions.cpp 85.14% <0.00%> (+0.10%) ⬆️
src/goto-instrument/dump_c.cpp 80.49% <0.00%> (+0.28%) ⬆️
src/goto-instrument/dump_c_class.h 100.00% <ø> (ø)
src/goto-instrument/goto_program2code.cpp 68.84% <0.00%> (+0.06%) ⬆️
src/goto-programs/goto_convert.cpp 92.33% <ø> (-0.01%) ⬇️
src/goto-programs/xml_expr.cpp 51.21% <0.00%> (ø)
src/util/expr_util.h 100.00% <ø> (ø)
src/util/pointer_predicates.cpp 93.10% <ø> (-0.45%) ⬇️
src/util/pointer_predicates.h 66.66% <ø> (ø)
src/analyses/custom_bitvector_analysis.cpp 55.96% <44.44%> (+0.07%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 352be59...143c49c. Read the comment docs.

This perhaps was meant to be "property_class," but really we should just
leave it as was provided in the source location.
@kroening kroening merged commit a2e51b6 into diffblue:develop Mar 1, 2022
@tautschnig tautschnig deleted the cleanup/property branch March 1, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants