Skip to content

CONTRACTS: remove redundant "::" in generated symbol names #6567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

tautschnig
Copy link
Collaborator

This is just a beautification of goto programs generated for contracts
checking: get_fresh_aux_symbol will add "::" in this place already, so
we ended up with "::::" in symbol names.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This is just a beautification of goto programs generated for contracts
checking: get_fresh_aux_symbol will add "::" in this place already, so
we ended up with "::::" in symbol names.
@tautschnig tautschnig force-pushed the contracts/four-colons branch from a7c4724 to 9ba013d Compare January 11, 2022 22:18
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #6567 (9ba013d) into develop (bd1401f) will increase coverage by 0.02%.
The diff coverage is 87.27%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6567      +/-   ##
===========================================
+ Coverage    75.99%   76.01%   +0.02%     
===========================================
  Files         1579     1579              
  Lines       181124   181304     +180     
===========================================
+ Hits        137643   137819     +176     
- Misses       43481    43485       +4     
Impacted Files Coverage Δ
src/ansi-c/c_typecheck_base.h 100.00% <ø> (ø)
src/ansi-c/expr2c_class.h 100.00% <ø> (ø)
src/ansi-c/expr2c.cpp 65.94% <6.25%> (-0.46%) ⬇️
src/ansi-c/c_typecheck_code.cpp 80.07% <83.33%> (+0.40%) ⬆️
jbmc/src/java_bytecode/java_pointer_casts.cpp 92.50% <100.00%> (-0.84%) ⬇️
...s/variable-sensitivity/interval_abstract_value.cpp 84.61% <100.00%> (-0.28%) ⬇️
src/ansi-c/c_expr.h 100.00% <100.00%> (ø)
src/ansi-c/parser.y 79.64% <100.00%> (+0.35%) ⬆️
src/goto-instrument/contracts/assigns.cpp 96.35% <100.00%> (+0.51%) ⬆️
src/goto-instrument/contracts/assigns.h 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 169dc18...9ba013d. Read the comment docs.

Copy link
Contributor

@SaswatPadhi SaswatPadhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tautschnig tautschnig merged commit 29584b3 into diffblue:develop Jan 12, 2022
@tautschnig tautschnig deleted the contracts/four-colons branch January 12, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants