Skip to content

Linking: do not modify source symbol table #6548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

tautschnig
Copy link
Collaborator

This makes the interface more intuitive and ensures that we do not leave
behind an inconsistent symbol table.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This makes the interface more intuitive and ensures that we do not leave
behind an inconsistent symbol table.
@codecov
Copy link

codecov bot commented Dec 27, 2021

Codecov Report

Merging #6548 (544fdf9) into develop (c7da320) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6548   +/-   ##
========================================
  Coverage    75.98%   75.98%           
========================================
  Files         1578     1578           
  Lines       181040   181044    +4     
========================================
+ Hits        137559   137563    +4     
  Misses       43481    43481           
Impacted Files Coverage Δ
src/linking/linking_class.h 100.00% <ø> (ø)
src/linking/linking.cpp 59.40% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 303b3aa...544fdf9. Read the comment docs.

@kroening kroening merged commit 73a1414 into diffblue:develop Dec 28, 2021
@tautschnig tautschnig deleted the linking-interface branch December 29, 2021 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants