Skip to content

Build with /usr/bin/clang on MacOS #6359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

markrtuttle
Copy link
Collaborator

This replaces #6344. The JDK 17 issues dealt with there are being fixed.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@markrtuttle markrtuttle requested a review from a team as a code owner September 22, 2021 12:22
Copy link
Contributor

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #6359 (c2effbf) into develop (9d774a7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6359      +/-   ##
===========================================
- Coverage    75.90%   75.90%   -0.01%     
===========================================
  Files         1515     1515              
  Lines       164002   164004       +2     
===========================================
+ Hits        124482   124483       +1     
- Misses       39520    39521       +1     
Impacted Files Coverage Δ
src/goto-analyzer/unreachable_instructions.cpp 90.95% <100.00%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e4b5c6...c2effbf. Read the comment docs.

@NlightNFotis NlightNFotis merged commit f616e29 into diffblue:develop Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants