Check subset relationship of assigns clause during replacement #6345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feliperodri
added
bugfix
aws
feliperodri
force-pushed
the
fix-contract-replacement
branch
from
289c957 to
cd5fef0
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6345 +/- ##
========================================
Coverage 75.90% 75.90%
========================================
Files 1515 1515
Lines 163990 164005 +15
========================================
+ Hits 124469 124484 +15
Misses 39521 39521
Continue to review full report at Codecov.
|
Signed-off-by: Felipe R. Monteiro <[email protected]>
feliperodri
force-pushed
the
fix-contract-replacement
branch
from
cd5fef0 to
5e8852b
Compare
feliperodri
requested review from
chrisr-diffblue,
kroening,
SaswatPadhi and
tautschnig
as code owners
Signed-off-by: Felipe R. Monteiro <[email protected]>
Signed-off-by: Felipe R. Monteiro <[email protected]>
feliperodri
force-pushed
the
fix-contract-replacement
branch
from
5e8852b to
b623a0b
Compare
SaswatPadhi
approved these changes
Sep 16, 2021
| @@ -7,7 +7,7 @@ main.c | |||
| \[postcondition.\d+\] file main.c line \d+ Check ensures clause: SUCCESS | |||
| \[bar.\d+\] line \d+ Check that z is assignable: SUCCESS | |||
| \[foo.\d+\] line \d+ Check that \*x is assignable: SUCCESS | |||
| \[foo.\d+\] line \d+ Check that callee's assigns clause is a subset of caller's: SUCCESS | |||
| \[foo.\d+\] line \d+ Check that bar\'s assigns clause is a subset of foo\'s assigns clause: SUCCESS | |||
| @@ -272,6 +272,7 @@ void ansi_c_convert_typet::read_rec(const typet &type) | |||
| for(auto &assignment : to_unary_expr(as_expr).op().operands()) | |||
| assigns.add_to_operands(std::move(assignment)); | |||
| } | |||
| assigns.add_source_location() = as_expr.source_location(); | |||
chrisr-diffblue
approved these changes
Sep 17, 2021
Signed-off-by: Felipe R. Monteiro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If CBMC replaces a function
bar()with its contract, while enforcing the contract in functionfoo(), it must also check whether thebar()'s assigns clause is a subset of thefoo()'s assigns clause.