Skip to content

Remove Pointer_byte_extract8 as it is no longer needed. #5917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NlightNFotis
Copy link
Contributor

It was noted in #2995
that this test is no longer needed as the case it tests for
is covered by Pointer_byte_extract5/no-simplify.desc

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

It was noted in diffblue#2995
that this test is no longer needed as the case it tests for
is covered by Pointer_byte_extract5/no-simplify.desc
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #5917 (e5e4a18) into develop (46449ee) will increase coverage by 0.18%.
The diff coverage is 96.13%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5917      +/-   ##
===========================================
+ Coverage    73.37%   73.55%   +0.18%     
===========================================
  Files         1428     1430       +2     
  Lines       155121   155222     +101     
===========================================
+ Hits        113813   114170     +357     
+ Misses       41308    41052     -256     
Impacted Files Coverage Δ
jbmc/src/java_bytecode/assignments_from_json.cpp 97.26% <ø> (ø)
jbmc/src/java_bytecode/java_class_loader.cpp 96.07% <ø> (ø)
jbmc/src/java_bytecode/java_object_factory.cpp 94.29% <ø> (ø)
src/analyses/reaching_definitions.cpp 77.58% <ø> (ø)
src/analyses/reaching_definitions.h 82.75% <ø> (ø)
...ses/variable-sensitivity/abstract_value_object.cpp 95.43% <ø> (ø)
...s/variable-sensitivity/interval_abstract_value.cpp 81.96% <ø> (ø)
...sitivity/variable_sensitivity_dependence_graph.cpp 84.58% <ø> (ø)
...variable-sensitivity/variable_sensitivity_domain.h 100.00% <ø> (ø)
...ensitivity/variable_sensitivity_object_factory.cpp 97.61% <ø> (ø)
... and 145 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1244577...e5e4a18. Read the comment docs.

@NlightNFotis NlightNFotis merged commit 51c59e9 into diffblue:develop Mar 12, 2021
@NlightNFotis NlightNFotis deleted the remove_pointer_byte_extract_test branch March 12, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants