Skip to content

Test Pointer_byte_extract8 now passes #2995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Test Pointer_byte_extract8 now passes #2995

wants to merge 1 commit into from

Conversation

kroening
Copy link
Member

@kroening kroening commented Sep 19, 2018 •
edited by danpoe
Loading

Pointer_byte_extract8 now passes, with minor adaptation to changes
that have happened in the meantime.

  • Each commit message has a non-empty body, explaining why the change was made.
  • My contribution is formatted in line with CODING_STANDARD.md.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Test Pointer_byte_extract8 now passes
119d9da 
Pointer_byte_extract8 now passes, with minor adaptation to changes
that have happened in the meantime.
@kroening kroening added the Tests label Sep 19, 2018
@tautschnig
Copy link
Collaborator

It would be desirable to git bisect this to identify which commit actually fixed the problem.

allredj
allredj reviewed Sep 19, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 119d9da).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85319556

tautschnig
tautschnig requested changes Sep 26, 2018
View reviewed changes
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe Pointer_byte_extract8 should be removed completely: we have Pointer_byte_extract5/no-simplify.desc (as of efea5c4) that covers this. It should probably have been removed as part of efea5c4 (sorry, my bad).

NlightNFotis added a commit to NlightNFotis/cbmc that referenced this pull request Mar 12, 2021
@NlightNFotis
Remove Pointer_byte_extract8 as it is no longer needed.
e5e4a18 
It was noted in diffblue#2995
that this test is no longer needed as the case it tests for
is covered by Pointer_byte_extract5/no-simplify.desc
@NlightNFotis NlightNFotis mentioned this pull request Mar 12, 2021
Merged
7 tasks
@NlightNFotis
Copy link
Contributor

I'm closing this PR, having created a new one (#5917) that implements the fix that Michael has blocked this PR on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@tautschnig tautschnig tautschnig requested changes

Assignees

@kroening kroening

Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kroening @tautschnig @NlightNFotis @allredj @chrisr-diffblue