Skip to content

Conversation

NlightNFotis
Copy link
Contributor

We used to have one in the Travis days, but somehow we lost
it when we removed the Travis configuration. This PR re-introduces it,
this time working on GitHub actions, along with updating the warnings
we are expecting.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This had been missed while we removed travis,
but it's useful to check for problems with
new documentation added.
@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #5645 (522f51e) into develop (e24faec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5645   +/-   ##
========================================
  Coverage    69.41%   69.41%           
========================================
  Files         1241     1241           
  Lines       100614   100614           
========================================
  Hits         69843    69843           
  Misses       30771    30771           
Flag Coverage Δ
cproversmt2 43.14% <ø> (ø)
regression 66.31% <ø> (ø)
unit 32.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e24faec...522f51e. Read the comment docs.

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies I thought I had fixed all of the doxygen issues in VSD.

Copy link
Contributor

@piotr-grabalski piotr-grabalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

/cbmc/src/goto-symex/symex_slice_class.h:25: warning: documented empty return type of symex_slicet::collect_open_variables
/home/runner/work/cbmc/cbmc/src/solvers/smt2/smt2_conv.h:113: warning: documented empty return type of smt2_convt::convert_rounding_mode_FPA
/home/runner/work/cbmc/cbmc/src/goto-symex/symex_slice_class.h:25: warning: documented empty return type of symex_slicet::collect_open_variables
/home/runner/work/cbmc/cbmc/src/goto-instrument/cover_basic_blocks.h:122: warning: argument 'block.' of command @param is not found in the argument list of cover_basic_blockst::add_block_lines(cover_basic_blockst::block_infot &block, const goto_programt::instructiont &instruction)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This warning does not seem to appear in the old version. This isn't a problem in itself, but the commit is claiming its only changing path and line numbers.


# Check doxygen version
EXPECTED_VERSION="1.8.16"
EXPECTED_VERSION="1.8.17"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a path or line number either.

@NlightNFotis NlightNFotis merged commit 4bd3c2f into diffblue:develop Dec 11, 2020
@NlightNFotis NlightNFotis deleted the doxygen-github-action branch December 11, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants