Skip to content

Conversation

kroening
Copy link
Member

@kroening kroening commented Nov 7, 2020

This constructor has been deprecated since September 2018. There are two
residual in-tree uses, which are replaced by the (simple) alternative.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • n/a My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This constructor has been deprecated since September 2018.  There are two
residual in-tree uses, which are replaced by the (simple) alternative.
@kroening kroening force-pushed the remove_parametert_constructor branch from 1272015 to 75f8490 Compare November 7, 2020 11:41
@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #5551 (75f8490) into develop (bf62883) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5551   +/-   ##
========================================
  Coverage    68.52%   68.52%           
========================================
  Files         1187     1187           
  Lines        98265    98265           
========================================
  Hits         67339    67339           
  Misses       30926    30926           
Flag Coverage Δ
cproversmt2 42.96% <ø> (ø)
regression 65.68% <100.00%> (ø)
unit 32.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/util/std_types.h 94.39% <ø> (ø)
jbmc/src/java_bytecode/lambda_synthesis.cpp 97.96% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf62883...75f8490. Read the comment docs.

@kroening kroening marked this pull request as ready for review November 7, 2020 12:58
@kroening kroening merged commit 8f83b7a into develop Nov 7, 2020
@kroening kroening deleted the remove_parametert_constructor branch November 7, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants