Add spell correction for CLI options #5461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannes-steffenhagen-diffblue
requested review from
kroening,
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
For now only basic levenshtein distance (delete,insert,modify). This is probably good enough for the intended use case (suggesting typo fixes on the command line).
This will provide some suggestions if a command line option is unknown, but similar to an option that *does* exist.
hannes-steffenhagen-diffblue
force-pushed
the
cmdline-spell-correction
branch
from
f359eab to
dcca3c5
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5461 +/- ##
===========================================
+ Coverage 68.25% 68.28% +0.02%
===========================================
Files 1180 1183 +3
Lines 97722 97807 +85
===========================================
+ Hits 66698 66783 +85
Misses 31024 31024
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
martin-cs
approved these changes
Aug 17, 2020
src/util/nfa.h
Outdated
| /// \file | ||
| /// \author Diffblue Ltd. | ||
| /// | ||
| /// A simple NFA implementation |
There was a problem hiding this comment.
Please could you add what it is intended for. There have been other automaton implementations in CPROVER (for SATAbs for example) and I wouldn't like future people to get the wrong idea of what this is.
There was a problem hiding this comment.
Good point, will do
chrisr-diffblue
approved these changes
Aug 26, 2020
peterschrammel
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives you some suggestions if you’ve mistyped a command line parameter.
E.g. on
cbmc --traecit will suggest--trace, if you typecbmc --cvcit will suggest trying--cvc3or--cvc4, that sort of thing.