Let with multiple bindings #5160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kroening
commented
Oct 10, 2019
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
kroening
force-pushed
the
let_with_multiple_bindings
branch
3 times, most recently
from
cb638c0 to
a76f57b
Compare
allredj
reviewed
Oct 11, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: a76f57b).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/131490735
romainbrenguier
approved these changes
Oct 11, 2019
kroening
force-pushed
the
let_with_multiple_bindings
branch
from
9d72b46 to
94f521f
Compare
added 3 commits
October 11, 2019 19:52
This avoids deeply recursive expressions.
This avoids deeply recursive expressions.
This avoids deeply recursive expressions.
kroening
force-pushed
the
let_with_multiple_bindings
branch
from
94f521f to
cd0d0f6
Compare
allredj
reviewed
Oct 11, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: cd0d0f6).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/131602265
peterschrammel
approved these changes
Oct 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.