Skip to content

SMT-LIB2 parameter/let/quantifier scopes #5158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2019
Merged

SMT-LIB2 parameter/let/quantifier scopes #5158

merged 1 commit into from
Oct 13, 2019

Conversation

kroening
Copy link
Member

@kroening kroening commented Oct 8, 2019

SMT-LIB2 function definitions have scopes for the identifiers of the parameters.

This was raised in #5143.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [n/a My commit message includes data points confirming performance improvements (if claimed).
  • n/a My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

allredj
allredj reviewed Oct 8, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: c75b2ab).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/131005570

@kroening kroening force-pushed the smt2_function_scoping_test branch 2 times, most recently from 8569ea4 to 48a1390 Compare October 9, 2019 08:36
@kroening kroening changed the title add test for SMT-LIB2 parameter scopes SMT-LIB2 parameter/let scopes Oct 9, 2019
fix for SMT-LIB2 scopes for function definitions and let
6eabb66 
SMT-LIB2 function definitions have scopes for the identifiers of the
parameters.  The same holds for let expressions.

This was raised in #5143.

The need to make the scoped identifiers unique will be removed once the IR
bindings have scopes.
@kroening kroening force-pushed the smt2_function_scoping_test branch from 48a1390 to 6eabb66 Compare October 9, 2019 13:51
@kroening kroening changed the title SMT-LIB2 parameter/let scopes SMT-LIB2 parameter/let/quantifier scopes Oct 9, 2019
allredj
allredj reviewed Oct 9, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 6eabb66).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/131189813

@kroening kroening merged commit e7fc79a into develop Oct 13, 2019
@kroening kroening deleted the smt2_function_scoping_test branch October 13, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@peterschrammel peterschrammel peterschrammel approved these changes

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs is a code owner

@romainbrenguier romainbrenguier Awaiting requested review from romainbrenguier

@tautschnig tautschnig Awaiting requested review from tautschnig

Assignees

@kroening kroening

Labels
bug Solvers Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kroening @peterschrammel @allredj