Skip to content

Tests for constant propagation of append(Object) #5122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

danpoe
Copy link
Contributor

@danpoe danpoe commented Sep 20, 2019

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@danpoe danpoe force-pushed the feature/append-object-constant-evaluation-tests branch from ff4bb23 to 906c2f3 Compare September 20, 2019 11:11
@codecov-io
Copy link

codecov-io commented Sep 20, 2019

Codecov Report

Merging #5122 into develop will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5122      +/-   ##
===========================================
+ Coverage    66.95%   66.99%   +0.04%     
===========================================
  Files         1145     1145              
  Lines        93650    93650              
===========================================
+ Hits         62699    62745      +46     
+ Misses       30951    30905      -46
Flag Coverage Δ
#cproversmt2 42.68% <ø> (ø) ⬆️
#regression 63.49% <ø> (+0.04%) ⬆️
#unit 31.7% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...lvers/strings/string_constraint_generator_main.cpp 85.05% <0%> (+0.57%) ⬆️
...rs/strings/string_constraint_generator_valueof.cpp 100% <0%> (+19.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20164f5...906c2f3. Read the comment docs.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 906c2f3).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/128502450

@danpoe danpoe merged commit afac9c7 into diffblue:develop Oct 11, 2019
@danpoe danpoe deleted the feature/append-object-constant-evaluation-tests branch June 2, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants