Skip to content

Tests for constant propagation of StringBuilder.append() #5114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
class Test {
public void testBooleanSuccess() {
StringBuilder sb = new StringBuilder("abc");
sb.append(true);
assert sb.toString().equals("abctrue");
}

public void testCharSuccess() {
StringBuilder sb = new StringBuilder("abc");
sb.append('a');
assert sb.toString().equals("abca");
}

public void testIntSuccess() {
StringBuilder sb = new StringBuilder("abc");
sb.append(3);
assert sb.toString().equals("abc3");
}

public void testLongSuccess() {
StringBuilder sb = new StringBuilder("abc");
sb.append(3L);
assert sb.toString().equals("abc3");
}

public void testCharSequenceSuccess() {
StringBuilder sb = new StringBuilder("abc");
CharSequence cs = "xyz";
sb.append(cs);
assert sb.toString().equals("abcxyz");
}

public void testStringBufferSuccess() {
StringBuilder sb = new StringBuilder("abc");
StringBuffer buf = new StringBuffer("xyz");
sb.append(buf);
assert sb.toString().equals("abcxyz");
}

public void testBooleanNoPropagation(boolean b) {
StringBuilder sb = new StringBuilder("abc");
sb.append(b);
assert sb.toString().equals("abctrue");
}

public void testCharNoPropagation(char c) {
StringBuilder sb = new StringBuilder("abc");
sb.append(c);
assert sb.toString().equals("abca");
}

public void testIntNoPropagation(int i) {
StringBuilder sb = new StringBuilder("abc");
sb.append(i);
assert sb.toString().equals("abc3");
}

public void testLongNoPropagation(long l) {
StringBuilder sb = new StringBuilder("abc");
sb.append(l);
assert sb.toString().equals("abc3");
}

public void testCharSequenceNoPropagation(CharSequence cs) {
StringBuilder sb = new StringBuilder("abc");
sb.append(cs);
assert sb.toString().equals("abcxyz");
}

public void testStringBufferNoPropagation(StringBuffer buf) {
StringBuilder sb = new StringBuilder("abc");
sb.append(buf);
assert sb.toString().equals("abcxyz");
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
CORE symex-driven-lazy-loading-expected-failure
Test.class
--function Test.testBooleanNoPropagation --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar` --property 'java::Test.testBooleanNoPropagation:(Z)V.assertion.1'
^Generated [0-9]+ VCC\(s\), 1 remaining after simplification$
^EXIT=10$
^SIGNAL=0$
^VERIFICATION FAILED$
--
--
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
CORE
Test.class
--function Test.testBooleanSuccess --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar`
^Generated [0-9]+ VCC\(s\), 0 remaining after simplification$
^EXIT=0$
^SIGNAL=0$
^VERIFICATION SUCCESSFUL$
--
--
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
CORE symex-driven-lazy-loading-expected-failure
Test.class
--function Test.testCharNoPropagation --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar` --property 'java::Test.testCharNoPropagation:(C)V.assertion.1'
^Generated [0-9]+ VCC\(s\), 1 remaining after simplification$
^EXIT=10$
^SIGNAL=0$
^VERIFICATION FAILED$
--
--
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
CORE symex-driven-lazy-loading-expected-failure
Test.class
--function Test.testCharSequenceNoPropagation --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar` --property 'java::Test.testCharSequenceNoPropagation:(Ljava/lang/CharSequence;)V.assertion.1'
^Generated [0-9]+ VCC\(s\), 1 remaining after simplification$
^EXIT=10$
^SIGNAL=0$
^VERIFICATION FAILED$
--
--
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
CORE
Test.class
--function Test.testCharSequenceSuccess --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar`
^Generated [0-9]+ VCC\(s\), 0 remaining after simplification$
^EXIT=0$
^SIGNAL=0$
^VERIFICATION SUCCESSFUL$
--
--
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
FUTURE
Test.class
--function Test.testCharSuccess --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar`
^Generated [0-9]+ VCC\(s\), 0 remaining after simplification$
^EXIT=0$
^SIGNAL=0$
^VERIFICATION SUCCESSFUL$
--
--
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
CORE symex-driven-lazy-loading-expected-failure
Test.class
--function Test.testIntNoPropagation --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar` --property 'java::Test.testIntNoPropagation:(I)V.assertion.1'
^Generated [0-9]+ VCC\(s\), 1 remaining after simplification$
^EXIT=10$
^SIGNAL=0$
^VERIFICATION FAILED$
--
--
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
CORE
Test.class
--function Test.testIntSuccess --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar`
^Generated [0-9]+ VCC\(s\), 0 remaining after simplification$
^EXIT=0$
^SIGNAL=0$
^VERIFICATION SUCCESSFUL$
--
--
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
CORE symex-driven-lazy-loading-expected-failure
Test.class
--function Test.testLongNoPropagation --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar` --property 'java::Test.testLongNoPropagation:(J)V.assertion.1'
^Generated [0-9]+ VCC\(s\), 1 remaining after simplification$
^EXIT=10$
^SIGNAL=0$
^VERIFICATION FAILED$
--
--
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
CORE
Test.class
--function Test.testLongSuccess --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar`
^Generated [0-9]+ VCC\(s\), 0 remaining after simplification$
^EXIT=0$
^SIGNAL=0$
^VERIFICATION SUCCESSFUL$
--
--
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
CORE symex-driven-lazy-loading-expected-failure
Test.class
--function Test.testStringBufferNoPropagation --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar` --property 'java::Test.testStringBufferNoPropagation:(Ljava/lang/StringBuffer;)V.assertion.1'
^Generated [0-9]+ VCC\(s\), 1 remaining after simplification$
^EXIT=10$
^SIGNAL=0$
^VERIFICATION FAILED$
--
--
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
CORE
Test.class
--function Test.testStringBufferSuccess --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar`
^Generated [0-9]+ VCC\(s\), 0 remaining after simplification$
^EXIT=0$
^SIGNAL=0$
^VERIFICATION SUCCESSFUL$
--
--
3 changes: 3 additions & 0 deletions jbmc/src/java_bytecode/java_string_library_preprocess.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1692,6 +1692,9 @@ void java_string_library_preprocesst::initialize_conversion_table()
cprover_equivalent_to_java_assign_and_return_function
["java::java.lang.StringBuilder.append:(Ljava/lang/String;)"
"Ljava/lang/StringBuilder;"] = ID_cprover_string_concat_func;
cprover_equivalent_to_java_assign_and_return_function
["java::java.lang.StringBuilder.append:(Ljava/lang/StringBuffer;)"
"Ljava/lang/StringBuilder;"] = ID_cprover_string_concat_func;
cprover_equivalent_to_java_assign_and_return_function
["java::java.lang.StringBuilder.appendCodePoint:(I)"
"Ljava/lang/StringBuilder;"]=
Expand Down