Clean-up constraint generation for insert builtin function #5063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now totally handled by the string_dependencies class.
romainbrenguier
requested review from
martin-cs and
peterschrammel
as code owners
peterschrammel
approved these changes
Aug 28, 2019
| /// 4. forall i in [offset', s1.length). res[i + s2.length] = s1[i] | ||
| /// This is equivalent to | ||
| /// `res=concat(substring(s1, 0, offset'), concat(s2, substring(s1, offset')))`. | ||
| /// \param fresh_symbol: generator of fresh symbols |
Member
There was a problem hiding this comment.
🚫 docs don't match signature
| } | ||
|
|
||
| protected: | ||
| explicit string_insertion_builtin_functiont( |
romainbrenguier
force-pushed
the
clean-up/constraint-generation2
branch
from
5024d67 to
adfa82a
Compare
romainbrenguier
requested review from
chrisr-diffblue,
kroening,
smowton and
tautschnig
as code owners
romainbrenguier
force-pushed
the
clean-up/constraint-generation2
branch
from
adfa82a to
9a066f1
Compare
smowton
approved these changes
Aug 28, 2019
martin-cs
approved these changes
Aug 28, 2019
romainbrenguier
force-pushed
the
clean-up/constraint-generation2
branch
3 times, most recently
from
239ae21 to
fc4baa4
Compare
allredj
reviewed
Aug 28, 2019
Contributor
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: fc4baa4).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/124918171
Codecov Report
@@ Coverage Diff @@
## develop #5063 +/- ##
===========================================
+ Coverage 69.51% 69.53% +0.01%
===========================================
Files 1314 1315 +1
Lines 108980 108967 -13
===========================================
+ Hits 75760 75766 +6
+ Misses 33220 33201 -19
Continue to review full report at Codecov.
|
Put all the code related to the builtin string_insert function to a string_insertion_builtin_function file.
The string preprocessing no longer produces calls to this builtin function which would have 3 arguments (in addition to the two string arguments) so the UNIMPLEMENTED case can be made into a precondition instead.
This is the only place where it is used, and the constraint method is very short so it makes sense to inline it there.
This is only used in one place and the code of both function is very short (trivial in one case) so it is better to merge them.
romainbrenguier
force-pushed
the
clean-up/constraint-generation2
branch
from
fc4baa4 to
3e1096d
Compare
allredj
reviewed
Aug 28, 2019
Contributor
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 3e1096d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/124929261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes.
This is a follow-up for #5035. Some code is now unreachable and can be removed, other parts can be moved to the string_insertion_builtin_function class to improve the structure of the code.