get_l1_object: only set L0 and L1 if they are non-empty #4923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
requested review from
kroening,
peterschrammel,
pkesseli and
tautschnig
as code owners
smowton
force-pushed
the
smowton/fix/get-l1-object-empty-strings
branch
from
72d4a33 to
be843a8
Compare
This is important because an expression "L0: '', L1: ''" is semantically equivalent to one with either index not specified at all, but they do not compare equal (irept::compare distinguishes an empty-string from an absent key), leading to confusing behaviour when ssa_exprts are used as keys in a map, for example.
smowton
force-pushed
the
smowton/fix/get-l1-object-empty-strings
branch
from
be843a8 to
56bb4c4
Compare
allredj
reviewed
Jul 23, 2019
Contributor
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 56bb4c4).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/120260619
peterschrammel
approved these changes
Jul 24, 2019
allredj
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important because an expression "L0: '', L1: ''" is semantically equivalent to
one with either index not specified at all, but they do not compare equal (irept::compare
distinguishes an empty-string from an absent key), leading to confusing behaviour when
ssa_exprts are used as keys in a map, for example.