Skip to content

Conversation

tautschnig
Copy link
Collaborator

We must not attempt to access the first operand of an array expression
when the array is empty. This case is explicitly considered earlier in
this method (an empty array is considered uniform), but value equality
constraints were attempted nevertheless.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

We must not attempt to access the first operand of an array expression
when the array is empty. This case is explicitly considered earlier in
this method (an empty array is considered uniform), but value equality
constraints were attempted nevertheless.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 282f5d5).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113346499

@tautschnig tautschnig merged commit f250e8b into diffblue:develop May 27, 2019
@tautschnig tautschnig deleted the empty-array branch May 27, 2019 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants