Skip to content

Rename lambda_exprt to array_comprehension_exprt #4683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2019
Merged

Rename lambda_exprt to array_comprehension_exprt #4683

merged 2 commits into from
May 22, 2019

Conversation

antlechner
Copy link
Contributor

As mentioned in a comment on #4672, this is a suggestion to rename the newly introduced type lambda_exprt to array_comprehension_exprt, which I find more intuitive. Some more documentation is also added.
If there is a good reason to keep the old name, or if another name would be more suitable, let me know and I'll change the first commit accordingly.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • n/a My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

antlechner added 2 commits May 21, 2019 17:08
@antlechner
Rename lambda_exprt to array_comprehension_exprt
2fbe5e1 
This kind of exprt does not represent lambda functions, but it
represents an array by specifying a range and a function operating on
the array indices.
This is a type of list/array comprehension, so calling it
array_comprehension_exprt is more descriptive of what this type is used
for.
@antlechner
Add documentation to array_comprehension_exprt
cd52307
thomasspriggs
thomasspriggs approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@thomasspriggs thomasspriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. 👍

tautschnig
tautschnig approved these changes May 22, 2019
View reviewed changes
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning this up!

@tautschnig tautschnig merged commit 9f06b86 into diffblue:develop May 22, 2019
@antlechner antlechner deleted the antonia/rename-lambda branch May 22, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tautschnig tautschnig tautschnig approved these changes

@thomasspriggs thomasspriggs thomasspriggs approved these changes

@smowton smowton Awaiting requested review from smowton

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs is a code owner

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antlechner @tautschnig @thomasspriggs