Skip to content

Regression tests: Ensure __LINE__ is expanded #4557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

tautschnig
Copy link
Collaborator

We previously generated several declarations with the same name, because
the C preprocessor does not expand LINE after a concatenation
operator. Add two levels of indirection to achieve this. Using
declarations with the same name was kind of ok for the C front-end, but
is a bug with any C++ front-end.

This is in preparation of running a subset of the C test against the C++ front-end.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

We previously generated several declarations with the same name, because
the C preprocessor does not expand __LINE__ after a concatenation
operator. Add two levels of indirection to achieve this. Using
declarations with the same name was kind of ok for the C front-end, but
is a bug with any C++ front-end.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: 949b116).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/108999105
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.

tautschnig added a commit that referenced this pull request Apr 24, 2019
Regression tests: Ensure __LINE__ is expanded
@tautschnig tautschnig merged commit 1217777 into diffblue:develop Apr 24, 2019
@tautschnig tautschnig merged commit 949b116 into diffblue:develop Apr 24, 2019
@tautschnig tautschnig deleted the __LINE__ branch April 24, 2019 10:08
@kroening
Copy link
Member

We could contemplate _Static_assert!

@tautschnig
Copy link
Collaborator Author

We could contemplate _Static_assert!

Hmm, yes, but then we'd also have to add -std=c11 to all the goto-cc invocations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants