Skip to content

added test for undeclared functions #4212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tautschnig merged 2 commits into from
Feb 21, 2019
Merged

added test for undeclared functions #4212

tautschnig merged 2 commits into from
Feb 21, 2019

Conversation

@kroening
Copy link
Collaborator

@kroening kroening commented Feb 17, 2019

Follow up from #4211. The type of function symbols must get fixed once the
function signature is known.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • n/a My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening force-pushed the undeclared_function branch from d344204 to 067c07e Compare February 17, 2019 09:30
@kroening kroening requested a review from tautschnig as a code owner February 17, 2019 09:30
@kroening kroening force-pushed the undeclared_function branch from 067c07e to 1288227 Compare February 17, 2019 09:37
allredj
allredj reviewed Feb 17, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: d344204).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/101217192
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

tautschnig
tautschnig reviewed Feb 17, 2019
View reviewed changes
src/goto-cc/compile.cpp Outdated
const std::string &file_name,
const goto_modelt &src_goto_model)
{
status() << "Validating goto model" << eom;
Copy link
Collaborator

@tautschnig tautschnig Feb 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be printed unconditionally?!

Copy link
Collaborator Author

@kroening kroening Feb 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

src/goto-cc/gcc_cmdline.cpp
"--big-endian",
"--no-arch",
"--partial-inlining",
"--validate-goto-model",
Copy link
Collaborator

@tautschnig tautschnig Feb 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add that to all modes, not just the GCC mode.

Copy link
Collaborator Author

@kroening kroening Feb 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

allredj
allredj reviewed Feb 17, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 1288227).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/101218026

@kroening
add --validate-goto-model to goto-cc
22ba1eb 
This enables tests of the validation without CBMC.
@kroening
added test for undeclared functions
7b72db5 
Follow up from #4211.  The type of function symbols must get fixed once the
function signature is known.
@kroening kroening force-pushed the undeclared_function branch from 1288227 to 7b72db5 Compare February 17, 2019 11:01
@kroening kroening removed their assignment Feb 17, 2019
allredj
allredj reviewed Feb 17, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 7b72db5).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/101219707

@tautschnig tautschnig merged commit febda72 into develop Feb 21, 2019
@tautschnig tautschnig deleted the undeclared_function branch February 21, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tautschnig tautschnig tautschnig approved these changes

+1 more reviewer

@allredj allredj allredj left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tautschnig tautschnig

Labels

bug C Front End Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kroening @tautschnig @allredj