use new goto_programt::instructiont API #4088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
requested review from
cesaro,
chrisr-diffblue,
cristina-david,
martin-cs,
NathanJPhillips,
peterschrammel,
pkesseli,
smowton,
tautschnig and
thk123
as code owners
kroening
force-pushed
the
goto_programt_code_cleanup
branch
from
6c36ca1 to
a5df597
Compare
tautschnig
reviewed
Feb 5, 2019
src/goto-programs/cfg.h
Outdated
| @@ -288,8 +288,7 @@ void cfg_baset<T, P, I>::compute_edges_function_call( | |||
| goto_programt::const_targett next_PC, | |||
| entryt &entry) | |||
| { | |||
| const exprt &function= | |||
| to_code_function_call(instruction.code).function(); | |||
| const exprt &function = instruction.get_function_call(); | |||
There was a problem hiding this comment.
This is missing a .function();
This increases type safety when accessing or construcing instructions of goto programs.
kroening
force-pushed
the
goto_programt_code_cleanup
branch
from
f138963 to
c56dbfd
Compare
allredj
reviewed
Feb 5, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: c56dbfd).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99818780
tautschnig
approved these changes
Feb 5, 2019
smowton
approved these changes
Feb 5, 2019
peterschrammel
approved these changes
Feb 5, 2019
peterschrammel
assigned
kroening and unassigned
smowton,
peterschrammel and
chrisr-diffblue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases type safety when accessing or construcing instructions of
goto programs.