Skip to content

Conversation

@allredj
Copy link
Contributor

@allredj allredj commented Jan 29, 2019

As a follow up to #3767 and to keep naming consistency between C and Java.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@thk123 thk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colour me a little terrified by this change

@allredj allredj force-pushed the java-rename-return-symbol branch 2 times, most recently from 51240cd to ac0075f Compare January 29, 2019 13:19
As a follow up to diffblue#3767 and to keep naming consistency between C and
Java.
@allredj allredj force-pushed the java-rename-return-symbol branch from ac0075f to 0f4ec5c Compare January 29, 2019 13:20
Copy link
Contributor Author

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 0f4ec5c).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98973103
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@allredj allredj merged commit aa93173 into diffblue:develop Jan 29, 2019
@allredj allredj deleted the java-rename-return-symbol branch January 29, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants