Skip to content

Conversation

@kroening
Copy link
Collaborator

This feature has no known users, and the code has no maintainer.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove the option from jbmc_parse_options.{h,cpp}, jdiff_parse_options.cpp.

This feature has no known users, and the code has no maintainer.
@kroening kroening force-pushed the remove_slice_by_trace branch from 7f35b02 to 636e952 Compare January 28, 2019 11:10
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 636e952).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98806153

@smowton
Copy link
Contributor

smowton commented Jan 28, 2019

For posterity (and potential future restoration), do you know what this originally intended to do?

@tautschnig tautschnig merged commit c442889 into develop Jan 29, 2019
@tautschnig tautschnig deleted the remove_slice_by_trace branch January 29, 2019 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants