smt2_solver: arrays #3521
smt2_solver: arrays #3521
Conversation
kroening
commented
Dec 3, 2018
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
kroening
requested review from
martin-cs,
peterschrammel and
tautschnig
as code owners
src/solvers/smt2/smt2_parser.cpp
Outdated
| { | ||
| // array index | ||
| if(op.size() != 2) | ||
| throw error("index takes two operands"); |
There was a problem hiding this comment.
Should this say "select"?
src/solvers/smt2/smt2_parser.cpp
Outdated
| throw error("index takes two operands"); | ||
|
|
||
| if(op[0].type().id() != ID_array) | ||
| throw error("index expects array operand"); |
There was a problem hiding this comment.
How about "select expects array as first operand"
src/solvers/smt2/smt2_parser.cpp
Outdated
| throw error("store expects array operand"); | ||
|
|
||
| if(to_array_type(op[0].type()).subtype() != op[2].type()) | ||
| throw error("store expects value that matches array elements"); |
There was a problem hiding this comment.
"... matches array element type"?
kroening
force-pushed
the
smt2_solver_arrays
branch
from
3b159c1 to
4f48501
Compare
There was a problem hiding this comment.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: 4f48501).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/93368956
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
kroening
force-pushed
the
smt2_solver_arrays
branch
from
4f48501 to
e28beab
Compare
kroening
force-pushed
the
smt2_solver_arrays
branch
from
e28beab to
e62c0ea
Compare
There was a problem hiding this comment.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: e62c0ea).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/93398589
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
