unicode characters for common sets of numbers #3198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kroening
commented
Oct 18, 2018
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
kroening
requested review from
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
allredj
reviewed
Oct 18, 2018
Contributor
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 4c94d85).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/88336371
tautschnig
approved these changes
Oct 18, 2018
smowton
reviewed
Oct 18, 2018
| else if(id == ID_c_bool) | ||
| return os << "c_bool[" << to_c_bool_type(type).get_width() << ']'; | ||
| else if(id == ID_bool) | ||
| return os << "\xf0\x9d\x94\xb9"; // u+1D539, 'B' |
Contributor
There was a problem hiding this comment.
Is that UTF-8 encoding? If so you might like to use u8"\U0001D539" in future rather than directly quote the encoded form
Contributor
There was a problem hiding this comment.
(\uNNNN for BMP characters like the three below)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.