Skip to content

Add sources for libstdc++6 >= 4.9 #3173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2018
Merged

Add sources for libstdc++6 >= 4.9 #3173

merged 1 commit into from
Oct 15, 2018

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Oct 15, 2018 •
edited
Loading

clang-format-6.0 requires a libstc++6 version newer than what Ubuntu 14.04 ships
by default; such a version is available from the ubuntu-toolchain-r-test PPA.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a My contribution is formatted in line with CODING_STANDARD.md.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig mentioned this pull request Oct 15, 2018
Merged
3 tasks
@chrisr-diffblue
Copy link
Contributor

I note that the CI job for clang-format is running git-clang-format-6.0, but the clang-format --version line is reporting 5.0.0.

@tautschnig
Add sources for libstdc++6 >= 4.9
5eebeaf 
clang-format-6.0 requires a libstc++6 version newer than what Ubuntu 14.04 ships
by default; such a version is available from the ubuntu-toolchain-r-test PPA.

Also fix the version information output to actually call the binary that is used
when calling git-clang-format-6.0.
@tautschnig
Copy link
Collaborator Author

@chrisr-diffblue Thanks a lot, good catch! I believe to have fixed this now.

chrisr-diffblue
chrisr-diffblue approved these changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@chrisr-diffblue chrisr-diffblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a code owner for this apparently (I though I was at one point) so you'll need another reviewer, but LGTM.

@tautschnig tautschnig mentioned this pull request Oct 15, 2018
Merged
3 tasks
allredj
allredj reviewed Oct 15, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 5eebeaf).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87938871

@tautschnig tautschnig merged commit 419031b into diffblue:develop Oct 15, 2018
@tautschnig tautschnig deleted the travis-clang-format branch October 15, 2018 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@thk123 thk123 thk123 approved these changes

@chrisr-diffblue chrisr-diffblue chrisr-diffblue approved these changes

@forejtv forejtv Awaiting requested review from forejtv

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

Assignees

@thk123 thk123

@peterschrammel peterschrammel

@forejtv forejtv

Labels
bugfix Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tautschnig @chrisr-diffblue @thk123 @allredj @peterschrammel @forejtv