Skip to content

Move to clang-format-6.0 and cleanup config #3148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

tautschnig
Copy link
Collaborator

As we are moving to clang-6.0 in other parts of the Travis configuration we
might as well use clang-format-6.0 in line with this. Also clean up the script
that used to ack around paths by just specifying the binary to use on the
command-line.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a My contribution is formatted in line with CODING_STANDARD.md.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

As we are moving to clang-6.0 in other parts of the Travis configuration we
might as well use clang-format-6.0 in line with this. Also clean up the script
that used to ack around paths by just specifying the binary to use on the
command-line.
@thk123
Copy link
Contributor

thk123 commented Oct 12, 2018

Might be worth running it across a folder as I seem to remember there was some undesirable consequences (hence using an old version in the first place).

@tautschnig
Copy link
Collaborator Author

I did run it across a few files and it seemed to me that any changes suggested were perfectly in line with our standards. If anyone knows files that should definitively be completely clang-format clean let me know...

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: ac3cb0f).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87754821

@tautschnig tautschnig merged commit d1b81ca into diffblue:develop Oct 12, 2018
@tautschnig tautschnig deleted the clang-format-6 branch October 12, 2018 17:16
@chrisr-diffblue
Copy link
Contributor

@tautschnig It looks like this PR has caused the clang-format job on travis to start failing due to apt dependencies. CI still looks green because the clang-format job is 'optional', but the clang-format job is red.

@tautschnig
Copy link
Collaborator Author

Yes, I have noticed this last night as well. Debugging this is the next item on my to-do list, just finishing up on PR.

@tautschnig
Copy link
Collaborator Author

Fixed in #3173.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants