use constructor for constant_exprt in convert_float_literal #3108
Conversation
kroening
commented
Oct 6, 2018
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- My contribution is formatted in line with CODING_STANDARD.md.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 853ebb2).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87108003
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 4813eba).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87108515
| } | ||
|
|
||
| ieee_floatt a(to_floatbv_type(result.type())); | ||
| ieee_floatt a(to_floatbv_type(type)); |
There was a problem hiding this comment.
How about we go one step further and fix up the return types of the float_type, double_type etc. to return a floatbv_typet? Then this would be ensured at compile-time rather than performing a run-time check?
There was a problem hiding this comment.
I'd say yes to that, but would make it a separate PR.
kroening
force-pushed
the
refactor_convert_float_literal
branch
from
4813eba to
bca1663
Compare
kroening
requested review from
peterschrammel,
pkesseli and
smowton
as code owners
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: bca1663).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87182849
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: bca1663).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87184017
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
